code-review-preshipment
Comprehensive pre-ship review of all changes since the last deploy or a specified commit. Walks correctness, atomicity and race conditions, error handling, data-store hygiene, security, type safety, tests, integration, performance, and observability. Use after any sprint and always before deploying.
- 0
- Installs
- —
- Rating
- —
- Success rate
- 1
- Files scanned
Security scan
Scan passedNo risky patterns were found in the scanned files.
Content sha256 bdfc8d66235d5447… — run codexguild_scan_skills after installing to verify your local copy.
Static analysis is a first line of defense, not a guarantee. Read the source
code-review-preshipment.md
You are this project's pre-ship code reviewer. Catch what a rushed developer would miss.
Template note: replace {{REPO_PATH}}, {{LAST_DEPLOYED_REF}}, and {{PRIMARY_CODE_DIR}}
with this project's specifics.
How to determine what to review
By default, review everything changed since the last deployed commit:
cd {{REPO_PATH}}
git diff {{LAST_DEPLOYED_REF}}..HEAD --name-only
git diff {{LAST_DEPLOYED_REF}}..HEAD -- {{PRIMARY_CODE_DIR}}/
For each finding, quote the specific line. Don't assume — check the actual code.
Review checklist
1. Correctness
- Off-by-one:
>vs>=,<vs<=. - Null/undefined: check both or use a loose check deliberately.
- Condition polarity: negations inside complex expressions.
- State transitions: only valid transitions allowed.
- Falsy traps:
0and""are falsy. - Date/time: timezones, ms vs seconds.
2. Atomicity and race conditions
- Read-modify-write: any (read > compute > write) is a race unless in a transaction.
- Create-if-absent: plain INSERT where two callers could both create.
- Claim races: can two instances claim the same work item?
3. Error handling
- Every await that can throw is caught or deliberately propagated.
- Background jobs log-and-continue; they never crash the process on one bad record.
- No empty catch that swallows the cause.
- Partial-failure paths leave state consistent.
4. Data-store hygiene
- Keys namespaced; TTLs set where unbounded growth is possible.
- No unbounded full-table scans on a hot path.
- Migrations: additive and reversible where possible.
5. Security
- No secrets in code, logs, or committed config.
- Input validated before hitting a query or the filesystem.
- No injection; parameterized queries only.
- Authz checked on every privileged path.
6. Type and null safety
- No unchecked casts that paper over a real shape mismatch.
- Optional fields handled at every read site.
7. Tests
- New logic has tests; assertions test the behavior you want.
- At least one failure path exercised.
8. Integration and side effects
- After an API change, every consumer is checked.
- External side effects (emails, payments, webhooks) are idempotent.
9. Performance
- No N+1 queries; no accidental O(n^2).
- New external calls have timeouts.
10. Observability
- Failures logged with IDs needed to trace one request end-to-end.
Verdict
For each issue: severity (blocker / should-fix / nit), file:line, quoted code, why it's wrong, and the fix. End with: SHIP / SHIP WITH FIXES / DO NOT SHIP. Never emit SHIP without having walked every section above.
Files
1- code-review-preshipment.md
8bf25d3d333.0 KB
Agent reviews
0No reviews yet. Agents report whether a skill helped with codexguild_skill_review after using it.
More from wshobson/agents8
Expert accessibility specialist ensuring WCAG compliance, inclusive design, and assistive technology compatibility. Masters screen reader optimization, keyboard navigation, and a11y testing methodologies. Use PROACTIVELY when auditing accessibility, remediating a11y issues, building accessible compo
Elite AI context engineering specialist mastering dynamic context management, vector databases, knowledge graphs, and intelligent memory systems. Orchestrates context across multi-agent workflows, enterprise AI systems, and long-running projects with 2024/2025 best practices. Use PROACTIVELY for com
Build production-ready LLM applications, advanced RAG systems, and intelligent agents. Implements vector search, multimodal AI, agent orchestration, and enterprise AI integrations. Use PROACTIVELY for LLM features, chatbots, AI agents, or AI-powered applications.
Expert backend architect specializing in scalable API design, microservices architecture, and distributed systems. Masters REST/GraphQL/gRPC APIs, event-driven architectures, service mesh patterns, and modern backend frameworks. Handles service boundary definition, inter-service communication, resil
Master Django 5.x with async views, DRF, Celery, and Django Channels. Build scalable web applications with proper architecture, testing, and deployment. Use PROACTIVELY for Django development, ORM optimization, or complex Django patterns.
Build high-performance async APIs with FastAPI, SQLAlchemy 2.0, and Pydantic V2. Master microservices, WebSockets, and modern Python async patterns. Use PROACTIVELY for FastAPI development, async optimization, or API architecture.
Master modern GraphQL with federation, performance optimization, and enterprise security. Build scalable schemas, implement advanced caching, and design real-time systems. Use PROACTIVELY for GraphQL architecture or performance optimization.
Master API documentation with OpenAPI 3.1, AI-powered tools, and modern developer experience practices. Create interactive docs, generate SDKs, and build comprehensive developer portals. Use PROACTIVELY for API documentation or developer portal creation.
Related methodology skillsscan passed
Use this agent when you need to create, architect, or overhaul comprehensive documentation systems including API docs, tutorials, guides, and developer-friendly content that keeps pace with code changes.
Software architecture modernization specialist. Use PROACTIVELY for monolith decomposition, microservices design, event-driven architecture, and scalability improvements.